PERF: Fixed decoding perf issue on py3 (GH5441) #5448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| f = np.vectorize(lambda x: x.decode(encoding), otypes=[np.object]) | ||
| data = f(data) | ||
| try: | ||
| data = data.astype(str).astype(object) |
There was a problem hiding this comment.
So this branch works when you only have ascii letters/numbers in your output? Otherwise always needs to be decoded, right?
There was a problem hiding this comment.
no it always works with an individual decoding, just slow. the astyping to str works when the input can be safely decoded by the astype(str) (which is prob just a UTF-8 decode on numpy side thats in c)
There was a problem hiding this comment.
Okay (I meant the astyping line) sounds good.
jreback
added a commit
that referenced
this pull request
Nov 6, 2013
PERF: Fixed decoding perf issue on py3 (GH5441)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5441