Skip to content

TST: More explicit test patterns #54463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 10, 2023
Merged

TST: More explicit test patterns #54463

merged 4 commits into from
Aug 10, 2023

Conversation

mroeschke
Copy link
Member

  • For commented out code, use xfails or uncomment working behavior
  • Instead of return, use pytest.skip

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Aug 8, 2023
@mroeschke mroeschke changed the title TST: More explicit test patters TST: More explicit test patterns Aug 8, 2023
@mroeschke mroeschke added this to the 2.1 milestone Aug 8, 2023
jbrockmendel
jbrockmendel reviewed Aug 9, 2023
View reviewed changes
pandas/tests/groupby/transform/test_transform.py
@@ -775,9 +775,7 @@ def frame_mi(frame):
{"by": np.random.default_rng(2).integers(0, 50, size=10).astype(float)},
{"level": 0},
{"by": "string"},
# {"by": 'string_missing'}]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no string_missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks added it back

@phofl phofl merged commit 40df396 into pandas-dev:main Aug 10, 2023
@phofl
Copy link
Member

phofl commented Aug 10, 2023

thx @mroeschke

@mroeschke mroeschke deleted the tst/more_explicit branch August 10, 2023 20:52
mroeschke added a commit to mroeschke/pandas that referenced this pull request Aug 18, 2023
@mroeschke
TST: More explicit test patterns (pandas-dev#54463)
83c26ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @phofl @jbrockmendel