REF: share BooleanArray tests with MaskedArray #54422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
reviewed
Aug 5, 2023
Comment on lines
1365
to
1369
| c = b | ||
| na = np.nan | ||
| dfg = pd.array([b, b, na, na, a, a, b, c], dtype="boolean") | ||
|
|
||
| df = DataFrame({"A": [1, 1, 2, 2, 3, 3, 1], "B": dfg[:-1]}) |
There was a problem hiding this comment.
nit: I see this was copied from a more generic test, should we clean up here? I.e. remove occurrences of c and dfg[:-1] -> dfg
mroeschke
added
Testing
mroeschke
approved these changes
Aug 5, 2023
|
Thanks @jbrockmendel |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
* REF: share BooleanArray tests with other Masked cases * REF: test_masked_numeric->test_masked * remove unnecessary slicing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mirror the layout in the pyarrow tests.