ENH: Update numpy exceptions imports #54405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsokol
force-pushed
the
update-np-exceptions-imports
branch
from
5d26681 to
4362824
Compare
lithomas1
reviewed
Aug 4, 2023
pandas/core/common.py
Outdated
| @@ -236,7 +238,8 @@ def asarray_tuplesafe(values: Iterable, dtype: NpDtype | None = None) -> ArrayLi | |||
| try: | |||
| with warnings.catch_warnings(): | |||
| # Can remove warning filter once NumPy 1.24 is min version | |||
| warnings.simplefilter("ignore", np.VisibleDeprecationWarning) | |||
| if Version(np.__version__) < Version("1.24.0"): | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Sure! I updated it to use these helpers.
mroeschke
added
the
Compat
mtsokol
force-pushed
the
update-np-exceptions-imports
branch
from
0ce64e0 to
3894c6e
Compare
lithomas1
approved these changes
Aug 7, 2023
mroeschke
approved these changes
Aug 7, 2023
|
Thanks @mtsokol |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
* ENH: Update numpy exceptions imports * ENH: Use version checks from dedicated utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to NumPy's main namespace being changed in numpy/numpy#24316, here I update warning imports.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.