TST: Use more pytest.importorskip #54377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Aug 2, 2023
mroeschke
commented
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
jbrockmendel
reviewed
Aug 2, 2023
| @pytest.mark.filterwarnings("ignore") | ||
| # Filter warnings when parallel=True and the function can't be parallelized by Numba | ||
| @pytest.mark.parametrize("jit", [True, False]) | ||
| @pytest.mark.parametrize("pandas_obj", ["Series", "DataFrame"]) | ||
| def test_cache(jit, pandas_obj, nogil, parallel, nopython): | ||
| # Test that the functions are cached correctly if we switch functions | ||
| pytest.importorskip("numba") |
There was a problem hiding this comment.
does this change the collection/running performance of the test suite?
There was a problem hiding this comment.
Collection locally I'm getting 35.19s on main vs 34.13s on the PR so negligible. Based on the job runtimes doesn't seem noticeably different
jbrockmendel
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.