BUG: is_list_like returns True even if __iter__ raises an error #54363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed so c_is_list_like() returns false if __iter__() throws exception
Updated to show fix to issue pandas-dev#54176
Changed so StringMethod objects are counted as list_like
mroeschke
requested changes
Aug 2, 2023
|
@mroeschke Is removing the implementation of is_list_like as it is and going in the direction of a handful of explicitly supported types the correct direction to go? |
|
IOW, I would recommend working on another issue in the meantime until this issue is more settled |
|
Thanks for the PR but going to close until there's more direction on the original issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed so c_is_list_like() returns false if iter() throws exception
doc/source/whatsnew/v2.1.0.rstfile if fixing a bug or adding a new feature.