Skip to content

TST: Add tests to ensure proper conversion of datetime64/timedelta64/timestamp/duration to and from pyarrow #54356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 9, 2023
Merged

TST: Add tests to ensure proper conversion of datetime64/timedelta64/timestamp/duration to and from pyarrow #54356

Changes from 9 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7fe4d10
add pyarrow conversion pytests
Julian048 Aug 1, 2023
eca3b3f
make test match GH issue and move test to proper location
Julian048 Aug 1, 2023
8a1a5be
fix naming of expected and result variables for assertion
Julian048 Aug 1, 2023
eecb330
optimize test
Julian048 Aug 1, 2023
dcfee47
Merge branch 'main' into add-pyarrow-conversion-tests
Julian048 Aug 1, 2023
c67a899
Merge branch 'main' of https://github.com/pandas-dev/pandas into add-…
Julian048 Aug 1, 2023
3f0e816
Merge branch 'add-pyarrow-conversion-tests' of https://github.com/Jul…
Julian048 Aug 1, 2023
d8ba4d2
Merge branch 'main' into add-pyarrow-conversion-tests
Julian048 Aug 2, 2023
f8e893d
Merge branch 'main' into add-pyarrow-conversion-tests
Julian048 Aug 4, 2023
28e2954
make test mirror GH #54191
Julian048 Aug 7, 2023
e9b6b90
Merge branch 'add-pyarrow-conversion-tests' of https://github.com/Jul…
Julian048 Aug 7, 2023
035935a
Merge branch 'main' into add-pyarrow-conversion-tests
Julian048 Aug 7, 2023
2960eb6
fix test logic
Julian048 Aug 9, 2023
9b0c833
Merge branch 'pandas-dev:main' into add-pyarrow-conversion-tests
Julian048 Aug 9, 2023
009808c
Merge branch 'main' of https://github.com/Julian048/pandas into add-p…
Julian048 Aug 9, 2023
9fc2082
Merge branch 'add-pyarrow-conversion-tests' of https://github.com/Jul…
Julian048 Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pandas/tests/frame/methods/test_convert_dtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,3 +167,18 @@ def test_convert_dtypes_pyarrow_to_np_nullable(self):
result = ser.convert_dtypes(dtype_backend="numpy_nullable")
expected = pd.DataFrame(range(2), dtype="Int32")
tm.assert_frame_equal(result, expected)

def test_convert_dtypes_timestamp_and_duration(self):
# GH 54191
pytest.importorskip("pyarrow")
timestamp_series = pd.Series(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mirror the exact code snippet in #54191 (comment)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what you're referencing right?
s = pd.Series(pd.date_range("2020-01-01", "2020-01-02", freq="1min"))
s = s.astype("timestamp[ms][pyarrow]")
t = s.convert_dtypes(dtype_backend="pyarrow")
pd.testing.assert_series_equal(s, t)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

pd.date_range("2020-01-01", "2020-01-02", freq="1440min")
).astype("timestamp[ms][pyarrow]")
duration_series = pd.Series(pd.timedelta_range("1s", "2s", freq="1s")).astype(
"duration[ms][pyarrow]"
)

expected = pd.concat([timestamp_series, duration_series], axis=1)
result = expected.convert_dtypes(dtype_backend="pyarrow")

tm.assert_frame_equal(expected, result)