-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Fixing EX01 - Added examples #54351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.. plot:: | ||
:context: close-figs | ||
|
||
>>> pd.plotting.register_matplotlib_converters() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this line? I think pandas should do it automatically
Could we explain that pandas does this automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And then note that if we manually prevent it from happening, then plotting for period fails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the first line because of Sphinx local fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, looks good to me on green!
Maybe we can reuse same example for deregister_matplotlib_converters
- it's close enough, and it enough to teach what the purpose of the method is
|
It's green |
Thanks @DeaMariaLeon |
Towards #37875
Sphinx acting weird locally :-/