Skip to content

DOC: Fixing EX01 - Added examples #54350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

DeaMariaLeon
Copy link
Member

Towards #37875

@DeaMariaLeon
Copy link
Member Author

/preview

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

No preview found for PR #54350. Did the docs build complete?

@DeaMariaLeon
Copy link
Member Author

/preview

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

No preview found for PR #54350. Did the docs build complete?

@MarcoGorelli
Copy link
Member

/preview

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

No preview found for PR #54350. Did the docs build complete?

@MarcoGorelli
Copy link
Member

No preview found for PR #54350. Did the docs build complete?

how odd, it shows here https://github.com/pandas-dev/pandas/actions/runs/5725144896?pr=54350

@MarcoGorelli
Copy link
Member

hey, this looks correct! 🙌

image

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @DeaMariaLeon

@datapythonista any idea why the preview isn't rendering? The docs build produced an artifact correctly, and I was able to download it and open the docs

@DeaMariaLeon DeaMariaLeon marked this pull request as ready for review August 1, 2023 15:13
@DeaMariaLeon DeaMariaLeon requested a review from mroeschke as a code owner August 1, 2023 15:13
@DeaMariaLeon
Copy link
Member Author

It's green

@mroeschke mroeschke added the Docs label Aug 1, 2023
@mroeschke mroeschke added this to the 2.1 milestone Aug 1, 2023
@mroeschke mroeschke merged commit ab85df4 into pandas-dev:main Aug 1, 2023
@mroeschke
Copy link
Member

Thanks @DeaMariaLeon

@DeaMariaLeon DeaMariaLeon deleted the 1Aug branch August 1, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants