Skip to content

ENH: allow opt-in to inferring pyarrow strings #54342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ENH: allow opt-in to inferring pyarrow strings #54342

wants to merge 1 commit into from

Conversation

jbrockmendel
Copy link
Member

cc @phofl

Enabling this at the top of conftest.py breaks 4290 tests.

@jbrockmendel jbrockmendel requested a review from WillAyd as a code owner August 1, 2023 03:03
phofl
phofl reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't add the warning for 2.1 (this is also consistent with the pdep), simply adding an option to convert should be good for now.

@jbrockmendel
Copy link
Member Author

I'm not as invested as you in getting this in for 2.1. Want to take over this PR?

@mroeschke mroeschke added Strings String extension data type and string data Arrow pyarrow functionality labels Aug 1, 2023
@phofl
Copy link
Member

phofl commented Aug 5, 2023

I have some trouble pushing to other forks, opened #54430 with tests and removed the comments

@jbrockmendel
Copy link
Member Author

Closing in favor of #54430

@jbrockmendel jbrockmendel deleted the enh-arrow-strings branch August 5, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

@WillAyd WillAyd Awaiting requested review from WillAyd

Assignees
No one assigned
Labels
Arrow pyarrow functionality Strings String extension data type and string data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @phofl @mroeschke