Skip to content

COMPAT: Pyarrow supports div with duration #54327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2023
Merged

COMPAT: Pyarrow supports div with duration #54327

merged 3 commits into from
Jul 31, 2023

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Compat pandas objects compatability with Numpy or Python functions Arrow pyarrow functionality labels Jul 31, 2023
@mroeschke mroeschke added this to the 2.1 milestone Jul 31, 2023
@jbrockmendel
Copy link
Member

LGTM pending greenish

@mroeschke mroeschke merged commit 206eb02 into pandas-dev:main Jul 31, 2023
@mroeschke mroeschke deleted the compat/pa/arith branch July 31, 2023 22:06
phofl
phofl reviewed Jul 31, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to test those properly. The type error is raised while constructing expected, not in the actual operation

@mroeschke
Copy link
Member Author

Yeah agreed. I'll reopen the issue and relabel it a testing issue

@mroeschke mroeschke mentioned this pull request Jul 31, 2023
Closed
@phofl
Copy link
Member

phofl commented Jul 31, 2023

Thx

@bnavigator bnavigator mentioned this pull request Sep 7, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

Assignees
No one assigned
Labels
Arrow pyarrow functionality Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

TST: div/truediv with PyArrow duration types
3 participants
@mroeschke @jbrockmendel @phofl