BUG: fix Resampling a Series with a timezone using kind='period' (GH5430) #5432
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1836,6 +1836,38 @@ def test_concat_datetime_datetime64_frame(self): | |||
| # it works! | |||
| pd.concat([df1, df2_obj]) | |||
|
|
|||
| def test_period_resample(self): | |||
| # #3609 | |||
There was a problem hiding this comment.
can you change this to GH3609 instead of #3609? just a stylistic thing.
|
You also need to squash all of your commits down to one. |
…cal timezone. Related to pandas-dev#5340. Signed-off-by: Kevin Stone <[email protected]> Added Test Case for pandas-dev#3609. Signed-off-by: Kevin Stone <[email protected]> Fixes Grouping by Period with Timezones The timestamp generated to partition the data frame doesn't include timezone information, so it was creating the wrong groups. It also had the frequency ('D') hard coded. Fixes pandas-dev#5340 and pandas-dev#3609. Signed-off-by: Kevin Stone <[email protected]>
|
@jtratner looks ok to me |
jtratner
added a commit
that referenced
this pull request
Nov 6, 2013
BUG: fix Resampling a Series with a timezone using kind='period' (GH5430)
|
Thanks for putting this together! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a failing test case and the patch in subsequent commits.
closes #5430
closes #3609