Skip to content

TST: Remove type-hint from test #54317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

TST: Remove type-hint from test #54317

merged 1 commit into from
Jul 31, 2023

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Followup to #54115. Having this type-hint makes mypy display

pandas/tests/frame/methods/test_shift.py:695: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]

@rhshadrach rhshadrach added Testing pandas testing functions or related to the test suite Clean labels Jul 31, 2023
@jona-sassenhagen
Copy link
Contributor

Sorry, I didn't realise that was introduced by my PR!

jona-sassenhagen
jona-sassenhagen approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@jona-sassenhagen jona-sassenhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mroeschke mroeschke added this to the 2.1 milestone Jul 31, 2023
@mroeschke mroeschke merged commit fe1a81e into pandas-dev:main Jul 31, 2023
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the remove_type_hint_from_test branch July 31, 2023 20:34
@rhshadrach
Copy link
Member Author

Sorry, I didn't realise that was introduced by my PR!

Not an issue; neither did I!

@code-narrator code-narrator mentioned this pull request Sep 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jona-sassenhagen jona-sassenhagen jona-sassenhagen approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@rhshadrach @jona-sassenhagen @mroeschke