Skip to content

BUG: raise a ParserWarning instead of printing to stderr when on_bad_lines is true #54309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

BUG: raise a ParserWarning instead of printing to stderr when on_bad_lines is true #54309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1ecf8a
fix: raise warning instead of printing to stderr when on_bad_lines is…
iboraham Jul 29, 2023
9641b23
fix ci fails
iboraham Jul 29, 2023
7321f97
add entry to v2.1.0.rst
iboraham Jul 29, 2023
823cff0
Merge branch 'main' into fix/read_csv-on_bad_line-raise-warning
iboraham Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v2.1.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,7 @@ I/O
- Bug in :func:`json_normalize`, fix json_normalize cannot parse metadata fields list type (:issue:`37782`)
- Bug in :func:`read_csv` where it would error when ``parse_dates`` was set to a list or dictionary with ``engine="pyarrow"`` (:issue:`47961`)
- Bug in :func:`read_csv`, with ``engine="pyarrow"`` erroring when specifying a ``dtype`` with ``index_col`` (:issue:`53229`)
- Bug in :func:`read_csv` was just printing to stderr while it should raise a warning when ``on_bad_line="warn"`` is set (:issue:`54296`)
- Bug in :func:`read_hdf` not properly closing store after a ``IndexError`` is raised (:issue:`52781`)
- Bug in :func:`read_html`, style elements were read into DataFrames (:issue:`52197`)
- Bug in :func:`read_html`, tail texts were removed together with elements containing ``display:none`` style (:issue:`51629`)
Expand Down
6 changes: 4 additions & 2 deletions pandas/_libs/parsers.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,9 +880,11 @@ cdef class TextReader:

cdef _check_tokenize_status(self, int status):
if self.parser.warn_msg != NULL:
print(PyUnicode_DecodeUTF8(
decoded_warning_message = PyUnicode_DecodeUTF8(
self.parser.warn_msg, strlen(self.parser.warn_msg),
self.encoding_errors), file=sys.stderr)
self.encoding_errors)
warnings.warn(decoded_warning_message, ParserWarning,
stacklevel=find_stack_level())
free(self.parser.warn_msg)
self.parser.warn_msg = NULL

Expand Down