Skip to content

DOCS: clarify self-merging and needs-triage #54286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2023
Merged

DOCS: clarify self-merging and needs-triage #54286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions doc/source/development/maintaining.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ Here's a typical workflow for triaging a newly opened issue.
unless it's know that this issue should be addressed in a specific release (say
because it's a large regression).

Once you have completed the above, make sure to remove the "needs triage" label.

.. _maintaining.regressions:

Investigating regressions
Expand Down Expand Up @@ -296,8 +298,11 @@ Merging pull requests

Only core team members can merge pull requests. We have a few guidelines.

1. You should typically not self-merge your own pull requests. Exceptions include
things like small changes to fix CI (e.g. pinning a package version).
1. You should typically not self-merge your own pull requests without approval.
Exceptions include things like small changes to fix CI
(e.g. pinning a package version). Self-merging with approval from other
core team members is fine if the change is something you're very confident
about.
2. You should not merge pull requests that have an active discussion, or pull
requests that has any ``-1`` votes from a core maintainer. pandas operates
by consensus.
Expand Down