STYL: replace autotyping with ruff's ANN autofixes #54260
Conversation
.pre-commit-config.yaml
Outdated
| @@ -25,6 +25,9 @@ repos: | |||
| hooks: | |||
| - id: ruff | |||
| args: [--exit-non-zero-on-fix] | |||
| - id: ruff | |||
| name: ruff's autotyping/flake8-annotations autofixes | |||
| args: [--select, ANN, --fix-only, --exit-non-zero-on-fix] | |||
There was a problem hiding this comment.
Could we just include ANN as a rule in pyproject.toml?
There was a problem hiding this comment.
I wish, but there are way too many violations (ANN wants everything to be annotated) and only some of them have in some cases an autofix. I would like only to use the autofixes. If there is a better way to achieve that, I'm all for that - but I didn't find one.
There was a problem hiding this comment.
Hmm since it appears ANN204 is the only auto-fix rule so far, could we just include that code?
There was a problem hiding this comment.
Let me put this back to draft and wait until #54271 is merged
There was a problem hiding this comment.
There are 191 methods without return annotations.
There was a problem hiding this comment.
I currently do not have time to add 191 return annotations but I will start working on it in the future.
ruff might have autofixes for ANN001 in the future astral-sh/ruff#1640
mroeschke
added
Code Style
|
Thanks @twoertwein |
ruff's ANN has many of the autofixes from autotyping but it doesn't have all of them. Ruff doesn't annotate parameters with simple default values (autotyping would change
def foo(x=1)todef foo(x: int = 1)).