ENH: Implement interchange protocol for DatetimeTZDtype #54246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Nice one, looks good to me
There should probably be a test for interchanging from non-pandas tz-aware, such as
pyarrow.Table
ts: timestamp[us, tz=Asia/Kathmandu]
----
ts: [[2019-12-31 18:15:00.000000,null,2020-01-01 18:15:00.000000]]?
Anyway, not a blocker, I can do that separately
| @@ -269,7 +274,11 @@ def _get_data_buffer( | |||
| DtypeKind.BOOL, | |||
| DtypeKind.DATETIME, | |||
| ): | |||
| buffer = PandasBuffer(self._col.to_numpy(), allow_copy=self._allow_copy) | |||
| if self.dtype[0] == DtypeKind.DATETIME and len(self.dtype[2]) > 4: | |||
There was a problem hiding this comment.
so anything longer than 'tsn:' will go here (like tss:US/Pacific), nice
There was a problem hiding this comment.
Yeah correct. Added a comment to that effect
Yes definitely. Would be good to have that as a follow up |
|
cool, I'll do that tomorrow |
jamie-harness
pushed a commit
to jamie-harness/pandas1
that referenced
this pull request
Jul 26, 2023
…4246) * ENH: Implement interchange protocol for DatetimeTZDtype * Add type ignores * Add comment
jamie-harness
added a commit
to jamie-harness/pandas1
that referenced
this pull request
Jul 26, 2023
…4246) (#36) * ENH: Implement interchange protocol for DatetimeTZDtype * Add type ignores * Add comment Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.