TST: add a test on mixed offsets for read_csv #54245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test looks good, but I think |
Thanks, I moved the test as you suggested. |
| @@ -2237,3 +2237,17 @@ def test_parse_dates_arrow_engine(all_parsers): | |||
| } | |||
| ) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_from_csv_with_mixed_offsets(): | |||
There was a problem hiding this comment.
does it work to use the
parser = all_parsers
and then
parser.read_csv
pattern from the other tests in this file?
There was a problem hiding this comment.
Yes, it works very well, except pyarrow. I added @xfail_pyarrow.
MarcoGorelli
approved these changes
Jul 25, 2023
|
Thank you for reviewing this PR. |
jamie-harness
pushed a commit
to jamie-harness/pandas1
that referenced
this pull request
Jul 26, 2023
* TST: add a test on mixed offsets for read_csv * change the location of the test * add parser to the test
jamie-harness
added a commit
to jamie-harness/pandas1
that referenced
this pull request
Jul 26, 2023
* TST: add a test on mixed offsets for read_csv * change the location of the test * add parser to the test Co-authored-by: Natalia Mokeeva <[email protected]>
jamie-harness
pushed a commit
to jamie-harness/pandas1
that referenced
this pull request
Jul 26, 2023
* TST: add a test on mixed offsets for read_csv * change the location of the test * add parser to the test
jamie-harness
added a commit
to jamie-harness/pandas1
that referenced
this pull request
Jul 26, 2023
* TST: add a test on mixed offsets for read_csv * change the location of the test * add parser to the test Co-authored-by: Natalia Mokeeva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #54014
added a test on mixed offsets to increase coverage for
read_csv