BLD: don't require ninja to come from PyPI #54244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pyproject.toml, the baseline requirements for building are supposed to be listed. Many end users have a recent enough system-provided ninja, and don't need to install a new copy into every pandas isolated build virtual environment. This is handled inside meson-python itself, which dynamically adds an additional build requirement on ninja via the backend hook `get_requires_for_build_sdist`, but only if a suitable system version is not found. This is especially helpful on systems where an OS ninja is installed, but the platform is obscure enough that there are no PyPI "ninja" wheels, thus forcing `pip install pandas` to download an additional copy of the ninja source code and build it via cmake before beginning to install pandas itself. This is not guaranteed to work... The ninja entry in various CI or developer-recommended workflows is left alone because they are opt-in. In such contexts, it may make sense to be fairly specific about which providers you want to use for any given dependency, and that's a workflow preference encoded as a workflow build command. Since it doesn't prevent people from using the baseline install command, this commit makes no value judgment regarding it.
eli-schwartz
force-pushed
the
pyproject-ninja
branch
from
de58e7c to
b74e215
Compare
eli-schwartz
changed the title
lithomas1
approved these changes
Jul 25, 2023
|
thanks @eli-schwartz. |
jamie-harness
pushed a commit
to jamie-harness/pandas1
that referenced
this pull request
Jul 26, 2023
In pyproject.toml, the baseline requirements for building are supposed to be listed. Many end users have a recent enough system-provided ninja, and don't need to install a new copy into every pandas isolated build virtual environment. This is handled inside meson-python itself, which dynamically adds an additional build requirement on ninja via the backend hook `get_requires_for_build_sdist`, but only if a suitable system version is not found. This is especially helpful on systems where an OS ninja is installed, but the platform is obscure enough that there are no PyPI "ninja" wheels, thus forcing `pip install pandas` to download an additional copy of the ninja source code and build it via cmake before beginning to install pandas itself. This is not guaranteed to work... The ninja entry in various CI or developer-recommended workflows is left alone because they are opt-in. In such contexts, it may make sense to be fairly specific about which providers you want to use for any given dependency, and that's a workflow preference encoded as a workflow build command. Since it doesn't prevent people from using the baseline install command, this commit makes no value judgment regarding it.
jamie-harness
added a commit
to jamie-harness/pandas1
that referenced
this pull request
Jul 26, 2023
In pyproject.toml, the baseline requirements for building are supposed to be listed. Many end users have a recent enough system-provided ninja, and don't need to install a new copy into every pandas isolated build virtual environment. This is handled inside meson-python itself, which dynamically adds an additional build requirement on ninja via the backend hook `get_requires_for_build_sdist`, but only if a suitable system version is not found. This is especially helpful on systems where an OS ninja is installed, but the platform is obscure enough that there are no PyPI "ninja" wheels, thus forcing `pip install pandas` to download an additional copy of the ninja source code and build it via cmake before beginning to install pandas itself. This is not guaranteed to work... The ninja entry in various CI or developer-recommended workflows is left alone because they are opt-in. In such contexts, it may make sense to be fairly specific about which providers you want to use for any given dependency, and that's a workflow preference encoded as a workflow build command. Since it doesn't prevent people from using the baseline install command, this commit makes no value judgment regarding it. Co-authored-by: Eli Schwartz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pyproject.toml, the baseline requirements for building are supposed to be listed.
Many end users have a recent enough system-provided ninja, and don't need to install a new copy into every pandas isolated build virtual environment. This is handled inside meson-python itself, which dynamically adds an additional build requirement on ninja via the backend hook
get_requires_for_build_sdist, but only if a suitable system version is not found.This is especially helpful on systems where an OS ninja is installed, but the platform is obscure enough that there are no PyPI "ninja" wheels, thus forcing
pip install pandasto download an additional copy of the ninja source code and build it via cmake before beginning to install pandas itself. This is not guaranteed to work...The ninja entry in various CI or developer-recommended workflows is left alone because they are opt-in. In such contexts, it may make sense to be fairly specific about which providers you want to use for any given dependency, and that's a workflow preference encoded as a workflow build command. Since it doesn't prevent people from using the baseline install command, this commit makes no value judgment regarding it.