Skip to content

STY: Enable ruff perflint #54236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 25, 2023
Merged

STY: Enable ruff perflint #54236

merged 5 commits into from
Jul 25, 2023

Conversation

mroeschke
Copy link
Member

No description provided.

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Jul 24, 2023
@jbrockmendel
Copy link
Member

Are these patterns supposed to be more performant?

@mroeschke
Copy link
Member Author

Are these patterns supposed to be more performant?

Supposedly https://beta.ruff.rs/docs/rules/manual-list-comprehension/

@mroeschke mroeschke added this to the 2.1 milestone Jul 24, 2023
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mroeschke mroeschke merged commit 2faf709 into pandas-dev:main Jul 25, 2023
@mroeschke mroeschke deleted the sty/ruff/more branch July 25, 2023 00:00
jamie-harness pushed a commit to jamie-harness/pandas1 that referenced this pull request Jul 25, 2023
* some check implmented

* Include rules

* Enable perflint

* type
jamie-harness added a commit to jamie-harness/pandas1 that referenced this pull request Jul 25, 2023
* some check implmented

* Include rules

* Enable perflint

* type

Co-authored-by: Matthew Roeschke <[email protected]>
jamie-harness pushed a commit to jamie-harness/pandas1 that referenced this pull request Jul 26, 2023
* some check implmented

* Include rules

* Enable perflint

* type
jamie-harness added a commit to jamie-harness/pandas1 that referenced this pull request Jul 26, 2023
* some check implmented

* Include rules

* Enable perflint

* type

Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants