Skip to content

CI: Try out pre-commit.ci again #54218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 28, 2023
Merged

Conversation

mroeschke
Copy link
Member

Will need to enable the pre-commit Github app

@mroeschke mroeschke added CI Continuous Integration Code Style Code style, linting, code_checks labels Jul 21, 2023
@MarcoGorelli
Copy link
Member

does it fit into the time limit now? I remember that being an issue, but now we've moved from flake8 to ruff and are building black using the wheels

@mroeschke
Copy link
Member Author

I still need to turn on the pre-commit Github app to test with this PR, but I'm hopeful that we shouldn't timeout anymore

@mroeschke
Copy link
Member Author

@MarcoGorelli looks like pre-commit CI completes in less than 3 minutes and the autofix PR feature is working pretty nicely

@mroeschke mroeschke added this to the 2.1 milestone Jul 27, 2023
@MarcoGorelli
Copy link
Member

oh wow, it's actually within the limit now! neat

@lithomas1
Copy link
Member

@MarcoGorelli looks like pre-commit CI completes in less than 3 minutes and the autofix PR feature is working pretty nicely

Pls turn off autofix. It was really annoying the last time it was briefly on, at least for me.

Is there a way to make it trigger on a comment instead (like the old comment bot)?

@mroeschke
Copy link
Member Author

Pls turn off autofix. It was really annoying the last time it was briefly on, at least for me.

Sure, just curious what you found annoying about autofix?

There is a separate command for running the fix if autofix is turned off

@lithomas1
Copy link
Member

Pls turn off autofix. It was really annoying the last time it was briefly on, at least for me.

Sure, just curious what you found annoying about autofix?

There is a separate command for running the fix if autofix is turned off

Mainly it just autopushing fixes, so then my local branch and the branch on github would be out of sync and conflict.
(so then I'd have to do a push and then pull).

Is there an opt out mechanism for users, or is autofix by repository?

@mroeschke
Copy link
Member Author

Is there an opt out mechanism for users, or is autofix by repository?

I think it's autofix by repo.

The latest commit has autofix turned off. A comment command to autofix is perfectly fine

@mroeschke
Copy link
Member Author

Since this new configuration is essentially preserves the same checking and autoupdating (the config not PRs) state as before just with pre-commit CI going to merge. Can follow up if needed

@mroeschke mroeschke merged commit a45c235 into pandas-dev:main Jul 28, 2023
@mroeschke mroeschke deleted the ci/pre-commit branch July 28, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants