-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CI: Try out pre-commit.ci again #54218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
does it fit into the time limit now? I remember that being an issue, but now we've moved from flake8 to ruff and are building black using the wheels |
I still need to turn on the pre-commit Github app to test with this PR, but I'm hopeful that we shouldn't timeout anymore |
@MarcoGorelli looks like pre-commit CI completes in less than 3 minutes and the autofix PR feature is working pretty nicely |
oh wow, it's actually within the limit now! neat |
Pls turn off autofix. It was really annoying the last time it was briefly on, at least for me. Is there a way to make it trigger on a comment instead (like the old comment bot)? |
Sure, just curious what you found annoying about autofix? There is a separate command for running the fix if autofix is turned off |
Mainly it just autopushing fixes, so then my local branch and the branch on github would be out of sync and conflict. Is there an opt out mechanism for users, or is autofix by repository? |
I think it's autofix by repo. The latest commit has autofix turned off. A comment command to autofix is perfectly fine |
Since this new configuration is essentially preserves the same checking and autoupdating (the config not PRs) state as before just with pre-commit CI going to merge. Can follow up if needed |
Will need to enable the pre-commit Github app