Skip to content

REF: more greppable names for ujson functions #54202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2023
Merged

REF: more greppable names for ujson functions #54202

merged 2 commits into from
Jul 20, 2023

Conversation

jbrockmendel
Copy link
Member

Discussed with @WillAyd

WillAyd
WillAyd approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm if green

pandas/_libs/src/vendored/ujson/python/ujson.c
@@ -54,14 +54,9 @@ PyObject *JSONToObj(PyObject *self, PyObject *args, PyObject *kwargs);
"encode_html_chars=True to encode < > & as unicode escape sequences."

static PyMethodDef ujsonMethods[] = {
{"encode", (PyCFunction)objToJSON, METH_VARARGS | METH_KEYWORDS,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize these even existed. Nice catch

@mroeschke
Copy link
Member 

pandas/io/json/_table_schema.py:16: error: Module "pandas._libs.json" has no attribute "ujson_loads"  [attr-defined]
pandas/io/json/_json.py:24: error: Module "pandas._libs.json" has no attribute "ujson_dumps"  [attr-defined]
pandas/io/json/_json.py:24: error: Module "pandas._libs.json" has no attribute "ujson_loads"  [attr-defined]
pandas/io/excel/_xlsxwriter.py:264: error: Module has no attribute "ujson_dumps"  [attr-defined]
pandas/io/excel/_odswriter.py:250: error: Module has no attribute "ujson_dumps"  [attr-defined]

@mroeschke mroeschke added the IO JSON read_json, to_json, json_normalize label Jul 20, 2023
@mroeschke mroeschke added this to the 2.1 milestone Jul 20, 2023
@mroeschke mroeschke merged commit be63ff5 into pandas-dev:main Jul 20, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-json-naming branch July 20, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach is a code owner

Assignees
No one assigned
Labels
IO JSON read_json, to_json, json_normalize
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @WillAyd