Skip to content

DOC: Simplify install.rst #54175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Conversation

mroeschke
Copy link
Member

  • Simplified some preamble
  • Updates some links and references
  • Removed installing via Linux package managers since this is not managed by the team

@mroeschke mroeschke added the Docs label Jul 18, 2023
@mroeschke mroeschke added this to the 2.1 milestone Jul 18, 2023
Copy link
Member

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks like a pretty good simplification.

Left some minor comments.


Installing from PyPI
~~~~~~~~~~~~~~~~~~~~

pandas can be installed via pip from
`PyPI <https://pypi.org/project/pandas>`__.

.. note::
You must have ``pip>=19.3`` to install from PyPI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep this in?

I don't know if people read this but, there used to be a bunch of bug reports from people unable to install pandas wheels since there pip was too old.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I can leave this in here

<https://docs.pytest.org/en/latest/>`__ >= 7.3.2 and `Hypothesis
<https://hypothesis.readthedocs.io/en/latest/>`__ >= 6.34.2, then run:
<https://hypothesis.readthedocs.io/en/latest/>`__ >= 6.34.2 to run. To run the tests from a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC you need more than this.

I think you need pytest-asyncio and pytest-localserver(??? not sure if this was removed).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized we have a pandas[test] extra that covers all the dependencies so I added it here.

@mroeschke mroeschke merged commit 406abd9 into pandas-dev:main Jul 19, 2023
@mroeschke mroeschke deleted the doc/install/simple branch July 19, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants