-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Simplify install.rst #54175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Simplify install.rst #54175
Conversation
mroeschke
commented
Jul 18, 2023
- Simplified some preamble
- Updates some links and references
- Removed installing via Linux package managers since this is not managed by the team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks like a pretty good simplification.
Left some minor comments.
|
||
Installing from PyPI | ||
~~~~~~~~~~~~~~~~~~~~ | ||
|
||
pandas can be installed via pip from | ||
`PyPI <https://pypi.org/project/pandas>`__. | ||
|
||
.. note:: | ||
You must have ``pip>=19.3`` to install from PyPI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you keep this in?
I don't know if people read this but, there used to be a bunch of bug reports from people unable to install pandas wheels since there pip was too old.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I can leave this in here
<https://docs.pytest.org/en/latest/>`__ >= 7.3.2 and `Hypothesis | ||
<https://hypothesis.readthedocs.io/en/latest/>`__ >= 6.34.2, then run: | ||
<https://hypothesis.readthedocs.io/en/latest/>`__ >= 6.34.2 to run. To run the tests from a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC you need more than this.
I think you need pytest-asyncio and pytest-localserver(??? not sure if this was removed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized we have a pandas[test]
extra that covers all the dependencies so I added it here.