BUG: iter(ser.str) did not raise TypeError #54174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Jul 18, 2023
pandas/core/strings/accessor.py
Outdated
| @@ -243,6 +243,9 @@ def __getitem__(self, key): | |||
| result = self._data.array._str_getitem(key) | |||
| return self._wrap_result(result) | |||
|
|
|||
| def __iter__(self): | |||
There was a problem hiding this comment.
__iter__: ClassVar[None] # type: ignore[assignment] could potentially help type checkers (I didn't try it) or using def __iter__(self) -> NoReturn:
There was a problem hiding this comment.
While this passes the is_list_like test, this appears not to completely address iter(ser.str) raising because iter still works because __getitem__ is defined
|
Looks like tests are passing here so merging. Happy to follow up if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.