DOC: Example missing in pandas.DataFrame.to_html #44945 #54153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Jul 17, 2023
pandas/core/frame.py
Outdated
| </tr> | ||
| </tbody> | ||
| </table> | ||
|
|
There was a problem hiding this comment.
Sure can, and thanks for your patience as I sort through these processes. Meanwhile, I have two real dumb questions that I hope you can help with ...
- I looked but I couldnt see where I can see the diff you pasted abov. Where would I have found that?
- I did in fact run the test locally and it appeared to pass. What's the magic incantation so I can run these tests locally before I commit?
OK I lied, I have a third question:
Q3: once I fix appropriately, do I just push into the same branch? I couldnt find a way to generate a new pull request so I assume it automatically knows to rerun the tests on my push, and does it just update the current open pull request?
Thanks again for your patience.
-VV
There was a problem hiding this comment.
…ed failing DataFrame.to_html() example
phofl
approved these changes
Aug 5, 2023
|
thx @vvaidy |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Uses the suggestion in the issue report as an example.
@noatamir @phofl SciPy 2023 sprint