Skip to content

ASV: update Fillna benchmarks for method parameter deprecation #54151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2023
Merged

ASV: update Fillna benchmarks for method parameter deprecation #54151

merged 3 commits into from
Jul 17, 2023

Conversation

lukemanley
Copy link
Member

@lukemanley lukemanley commented Jul 16, 2023 •
edited
Loading

Updates various Fillna benchmarks to not use method as method has been deprecated in favor of DataFrame.ffill and DataFrame.bfill.

Also, removed reindex.Fillna ASV as it was just a subset of series_methods.Fillna.

@lukemanley lukemanley added the Benchmark Performance (ASV) benchmarks label Jul 16, 2023
@lukemanley lukemanley added this to the 2.1 milestone Jul 16, 2023
@lukemanley lukemanley changed the title ASV: update frame_methods.Fillna for method parameter deprecation ASV: update Fillna benchmarks for method parameter deprecation Jul 16, 2023
@mroeschke mroeschke merged commit c64240c into pandas-dev:main Jul 17, 2023
@mroeschke
Copy link
Member

Thanks @lukemanley

@lukemanley lukemanley deleted the asv-frame-fillna branch July 25, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lukemanley @mroeschke