-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Provide examples of using read_parquet #49739 #54150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed typos that were causing tests to fail. Oops.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comments
pandas/io/parquet.py
Outdated
|
||
Examples | ||
-------- | ||
>>> import pandas as pd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be removed (it fails a check).
pandas/io/parquet.py
Outdated
foo bar | ||
0 3 8 | ||
1 4 9 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blank line here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed and pushed. Tested locally with ci/code_checks.sh docstrings
and seems to check clean
…rmatting failed checks
Can you remove |
…d read_parquet from code_checks.sh as requested by @mroeschke
Hi @mroeschke, No problem. I did as you requested and reran the tests locally and they succeeded. I must confess I don't quite understand the implications of that change, but I will look it over later tonight. In the meanwhile, it's done, tested locally and pushed. Do LMK if you need anything else. Thx. |
Thanks @vvaidy |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.@noatamir @phofl SciPy 2023 sprint