Add type literals to engine argument in groupby aggregations #54141

ankile · 2023-07-15T17:04:35Z

closes https://github.com/noatamir/scipy-2023-sprint/issues/7 groupby.py
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
Tests added and passed if fixing a bug or adding a new feature

@noatamir @phofl SciPy 2023 Sprint!

pandas/core/groupby/groupby.py

phofl · 2023-07-17T17:52:17Z

ankile added 2 commits July 15, 2023 11:42

Add engine types to groupby methods

c4106a6

Make docstring template for groupby aggregations with engine arg

c32fa53

ankile requested a review from rhshadrach as a code owner July 15, 2023 17:04

noatamir added the Sprints Sprint Pull Requests label Jul 15, 2023

ankile changed the title ~~Typing/groupby engine~~ Add type literals to engine argument in groupby aggregations Jul 15, 2023

phofl added the Typing type annotations, mypy/pyright type checking label Jul 17, 2023

phofl added this to the 2.1 milestone Jul 17, 2023

phofl approved these changes Jul 17, 2023

View reviewed changes

pandas/core/groupby/groupby.py Outdated Show resolved Hide resolved

Update pandas/core/groupby/groupby.py

755a925

phofl merged commit 098a569 into pandas-dev:main Jul 17, 2023

Provide feedback