Update the double quotes for the NA value to single quotes #54136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Tianye-Song, thanks for taking this on! Just a note for when you make this update that there are other functions that use this parameter whose docstrings may also need to be updated. Also, I noticed the title you have here is about adding single quotes instead of double quotes; however, I think the idea was to add double back-ticks to add code style formatting so that each is clearly a string literal. That may be what you meant but just wanted to confirm. Thanks again! |
|
/preview |
|
Website preview of this PR available at: https://pandas.pydata.org/preview/54136/ |
phofl
reviewed
Jul 17, 2023
Co-authored-by: Patrick Hoefler <[email protected]>
phofl
approved these changes
Jul 21, 2023
|
thx @Tianye-Song |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_csvdescription #54107 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.