Skip to content

Add type literal to engine argument in rolling functions #54135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2023
Merged

Add type literal to engine argument in rolling functions #54135

merged 3 commits into from
Jul 17, 2023

Conversation

ankile
Copy link
Contributor

@ankile ankile commented Jul 15, 2023 •
edited
Loading

@noatamir @phofl SciPy 2023 Sprint

@noatamir noatamir added the Sprints Sprint Pull Requests label Jul 15, 2023
phofl
phofl approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@phofl phofl added the Typing type annotations, mypy/pyright type checking label Jul 17, 2023
@phofl phofl merged commit 713fa7b into pandas-dev:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Sprints Sprint Pull Requests Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankile @phofl @noatamir