BUG: Series.groupby.size returning int64 for masked and arrow types #54132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Groupby
NA - MaskedArrays
mroeschke
changed the title
rhshadrach
requested changes
Jul 15, 2023
| @@ -2890,12 +2891,21 @@ def size(self) -> DataFrame | Series: | |||
| Freq: MS, dtype: int64 | |||
| """ | |||
| result = self.grouper.size() | |||
| result_dtype: str | np.dtype = result.dtype | |||
| if isinstance(self.obj, Series): | |||
There was a problem hiding this comment.
can we just use convert_dtypes for this? I think you've got another PR doing something similar for another method?
(i actually think for methods that return ints-and-never-NAs it is more useful to return non-nullable dtype, but whatever)
There was a problem hiding this comment.
can we just use convert_dtypes for this?
Sure, I will still have to do this original-object introspection though to set the correct dtype_backend for convert_dtype if that's alright with you
There was a problem hiding this comment.
Used convert_dtypes instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.