DOC: Fixing EX01 - Added example #54126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested changes
Jul 14, 2023
mroeschke
reviewed
Jul 14, 2023
mroeschke
reviewed
Jul 14, 2023
DeaMariaLeon
changed the title
mroeschke
reviewed
Jul 14, 2023
|
Looks good. Could you merge main once more? |
MarcoGorelli
approved these changes
Jul 18, 2023
pandas/core/frame.py
Outdated
Comment on lines
2113
to
2114
| >>> project_id = "my-project" # doctest: +SKIP | ||
| >>> table_id = 'my_dataset.my_table' # doctest: +SKIP |
There was a problem hiding this comment.
do these need skipping because otherwise flake8 complains they're unused?
There was a problem hiding this comment.
Good question, the skipping was not needed. I removed them.
flake8 complained earlier when the variables were not declared, but it was not related to the doctest skip.
|
It looks green if someone very kind wants to merge, it would be great. |
mroeschke
approved these changes
Jul 18, 2023
|
Thanks @DeaMariaLeon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #37875
Modifiedvalidate_docstrings.py: it was raising for "importing pandas". If I didn't import pandas_gbq on the docstring, the error was for undeclared name.Not sure if I have to add a test for that case or if the fix is good enough.