Skip to content

BLD: Update Gitpod to use docker installation flow and pip/meson for setup #54046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jul 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
850df73
Update Dockerfile with new Conda version
theuerc Jul 7, 2023
b9723f5
Update .gitpod.yml with meson build instructions
theuerc Jul 7, 2023
d59ce18
Update .gitpod.yml with new Dockerfile
theuerc Jul 7, 2023
91b1af4
Remove lines that cause errors in .gitpod.yml
theuerc Jul 7, 2023
ecc5361
add precommit hook back
theuerc Jul 7, 2023
e60ab0f
Merge branch 'pandas-dev:main' into gitpod_conda
theuerc Jul 7, 2023
295c663
Update gitpod.yml to use docker installation flow
theuerc Jul 7, 2023
c7e65e3
Remove outdated plugin configs
theuerc Jul 7, 2023
0535c97
remove trailing whitespace
theuerc Jul 7, 2023
12571cc
Update .gitpod.yml to remove conda activation (using docker flow)
theuerc Jul 8, 2023
a76e3be
fix esbonio language server not installed error
theuerc Jul 8, 2023
5a36bdb
Add pip/meson build to command to fix issues with gitpod prebuild
theuerc Jul 8, 2023
cfd1115
remove esbonio
theuerc Jul 8, 2023
8840434
enable prebuilds to quickly access pull requests
theuerc Jul 8, 2023
99bdebc
add statement to close terminal
theuerc Jul 8, 2023
4d85f4a
Remove extra pip/meson command
theuerc Jul 8, 2023
04d8ee2
add comma
theuerc Jul 8, 2023
5aa989d
add back duplicate command to fix prebuild
theuerc Jul 8, 2023
8837583
remove prebuilds for branches/forks
theuerc Jul 8, 2023
85c7fb1
remove pull request prebuild option
theuerc Jul 8, 2023
7436d84
Update gitpod comments
theuerc Jul 8, 2023
632c5f9
Merge branch 'pandas-dev:main' into docker_conda_gitpod
theuerc Jul 9, 2023
f06ffc9
update letter
theuerc Jul 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .gitpod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,20 @@
# https://www.gitpod.io/docs/config-start-tasks/#configuring-the-terminal
# -------------------------------------------------------------------------

# assuming we use dockerhub: name of the docker user, docker image, tag, e.g. https://hub.docker.com/r/pandas/pandas-gitpod/tags
image: pandas/pandas-gitpod:latest
# images for gitpod pandas are in https://hub.docker.com/r/pandas/pandas-gitpod/tags
# we're using the Dockerfile in the base of the repo
image:
file: Dockerfile
tasks:
- name: Prepare development environment
init: |
mkdir -p .vscode
cp gitpod/settings.json .vscode/settings.json
conda activate pandas-dev
git pull --unshallow # need to force this else the prebuild fails
git fetch --tags
python setup.py build_ext --inplace -j 4
echo "🛠 Completed rebuilding Pandas!! 🛠 "
python -m pip install -ve . --no-build-isolation --config-settings editable-verbose=true
pre-commit install
command: |
python -m pip install -ve . --no-build-isolation --config-settings editable-verbose=true
echo "✨ Pre-build complete! You can close this terminal ✨ "

# --------------------------------------------------------
Expand All @@ -37,7 +38,7 @@ vscode:
# avoid adding too many. they each open a pop-up window

# --------------------------------------------------------
# using prebuilds for the container
# Using prebuilds for the container
# With this configuration the prebuild will happen on push to main
github:
prebuilds:
Expand Down
2 changes: 1 addition & 1 deletion gitpod/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
# OS/ARCH: linux/amd64
FROM gitpod/workspace-base:latest

ARG MAMBAFORGE_VERSION="22.9.0-1"
ARG MAMBAFORGE_VERSION="23.1.0-3"
ARG CONDA_ENV=pandas-dev
ARG PANDAS_HOME="/home/pandas"

Expand Down
5 changes: 2 additions & 3 deletions gitpod/settings.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"restructuredtext.updateOnTextChanged": "true",
"restructuredtext.updateDelay": 300,
"esbonio.server.pythonPath": "/usr/local/bin/python",
"restructuredtext.linter.disabledLinters": ["doc8","rst-lint", "rstcheck"],
"python.defaultInterpreterPath": "/home/gitpod/mambaforge3/envs/pandas-dev/bin/python"
"python.defaultInterpreterPath": "/usr/local/bin/python"
}