Skip to content

CoW: Add ChainedAssignmentError for update #54024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2023
Merged

CoW: Add ChainedAssignmentError for update #54024

merged 2 commits into from
Jul 11, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Jul 6, 2023 •
edited by jorisvandenbossche
Loading

xref #48998

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl requested a review from jorisvandenbossche July 6, 2023 19:48
@phofl phofl added this to the 2.1 milestone Jul 6, 2023
@jorisvandenbossche jorisvandenbossche mentioned this pull request Jul 11, 2023
Open
38 tasks
jorisvandenbossche
jorisvandenbossche approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

A comment on the message that was added in the previous PR: maybe we should make it a bit clearer and change "chained assignment" -> "inplace method" ? (given this PR looks ready, we can do that in another PR)

@jorisvandenbossche jorisvandenbossche merged commit 926403d into pandas-dev:main Jul 11, 2023
@phofl phofl deleted the cow_update_inplace branch July 28, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Copy / view semantics
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @jorisvandenbossche @mroeschke