CoW: Add ChainedAssignmentError for replace with inplace=True #54023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
pandas/core/generic.py
Outdated
| @@ -7611,6 +7611,16 @@ def replace( | |||
| ) | |||
|
|
|||
| inplace = validate_bool_kwarg(inplace, "inplace") | |||
| if inplace: | |||
| if not PYPY and using_copy_on_write(): | |||
| refcount = 2 if PY311 else 3 | |||
There was a problem hiding this comment.
This can be updated now the other PR is merged
Comment on lines
71
to
78
| pd.Series(cat, copy=False).replace(to_replace, value, inplace=True) | ||
| if using_copy_on_write: | ||
| with tm.raises_chained_assignment_error(): | ||
| pd.Series(cat, copy=False).replace(to_replace, value, inplace=True) | ||
| else: | ||
| pd.Series(cat, copy=False).replace(to_replace, value, inplace=True) | ||
| tm.assert_categorical_equal(cat, expected) |
There was a problem hiding this comment.
In this case, I assume we are not necessarily testing that it is done on a single line, but just that the inplace works (and updates the underlying array. So I think it might be better to change the test to:
ser = pd.Series(cat, copy=False)
ser.replace(to_replace, value, inplace=True)
which should then work the same for both CoW and not?
There was a problem hiding this comment.
Don't care much either way, updated the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #48998
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.