Skip to content

DOC: Fixing EX01 - Added examples #54004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

DeaMariaLeon
Copy link
Member

Towards #37875

It wasn't possible to make the html files locally to preview the examples.

@DeaMariaLeon DeaMariaLeon requested a review from mroeschke as a code owner July 5, 2023 11:51
@DeaMariaLeon DeaMariaLeon requested a review from MarcoGorelli July 5, 2023 11:51
@DeaMariaLeon DeaMariaLeon added this to the 2.1 milestone Jul 5, 2023
dedent(
"""\
>>> ser = pd.Series([1, 2, 3, 4])
>>> ser.ewm(alpha=.2).mean()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I don't know how hard it is, but for a simple example like this one, would it be feasible to show how the result is calculated? like, to match it with just simple numpy operations?

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed earlier, a pure-numpy reproduction would be way too complex for the docstrings, so let's ship this as-is

@MarcoGorelli MarcoGorelli merged commit 0751cf2 into pandas-dev:main Jul 6, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@DeaMariaLeon DeaMariaLeon deleted the Jul5 branch July 18, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants