TST: add test to check dtype after replacing values in categorical Series inplace #53993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mroeschke, I added a test to check if the |
phofl
reviewed
Jul 6, 2023
| result = pd.Series(data, dtype="category") | ||
| result.replace(to_replace="a", value="b", inplace=True) | ||
| expected = pd.Series(data_exp, dtype="category") | ||
| tm.assert_index_equal(expected.dtype.categories, result.dtype.categories) |
There was a problem hiding this comment.
Is this not covered by tm.assert_series_equal?
There was a problem hiding this comment.
Yes, tm.assert_series_equal(result, expected) should be sufficient
There was a problem hiding this comment.
Thank you, I replaced tm.assert_index_equal with tm.assert_series_equal.
mroeschke
approved these changes
Jul 7, 2023
|
Thanks @natmokval |
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…ries inplace (pandas-dev#53993) * TST: add test to check dtype after replacing categorical Series inplace * replace tm.assert_index_equal with tm.assert_series_equal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes BUG:
Series.replacedoesn't updateCategoricalDtypewheninplace=Truein pandas-2.0 #53358added a test in order to check if the
dtypeis being updated, when we replace values in a categorical Series withinplace=True.