Skip to content

BUG: Changed function signature to replace args and kwargs #53965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from

Conversation

rsm-23
Copy link
Contributor

@rsm-23 rsm-23 commented Jul 1, 2023

@rsm-23 rsm-23 requested a review from rhshadrach as a code owner July 1, 2023 18:57
@rhshadrach
Copy link
Member

Changes look good, but are causing some uncaught warnings in the tests.

@rsm-23 rsm-23 force-pushed the modify-function-signature branch from 8432b2d to e0f3b1d Compare July 4, 2023 15:33
@rsm-23 rsm-23 force-pushed the modify-function-signature branch from 81b38cd to 1e26a75 Compare July 4, 2023 18:07
@rsm-23
Copy link
Contributor Author

rsm-23 commented Jul 6, 2023

Getting this error: Is it safe to change the superclass definition? @rhshadrach
pandas/core/frame.py:11132: error: Signature of "cumsum" incompatible with supertype "NDFrame" [override] pandas/core/frame.py:11132: note: Superclass: pandas/core/frame.py:11132: note: def cumsum(self, axis: Optional[Union[int, Literal['index', 'columns', 'rows']]] = ..., skipna: bool = ..., *args: Any, **kwargs: Any) -> Any pandas/core/frame.py:11132: note: Subclass: pandas/core/frame.py:11132: note: def cumsum(self, axis: Optional[Union[int, Literal['index', 'columns', 'rows']]] = ..., numeric_only: bool = ..., skipna: bool = ..., *args: Any, **kwargs: Any) -> Any

@rhshadrach
Copy link
Member

Yes - you'll also need to change the signature in NDFrame as well.

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Add numeric_only to function signature of DataFrameGroupBy.cumprod and `DataFrameGroupBy.cumsum
3 participants