-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Changed function signature to replace args and kwargs #53965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes look good, but are causing some uncaught warnings in the tests. |
8432b2d
to
e0f3b1d
Compare
81b38cd
to
1e26a75
Compare
* Added note for corr * Removed additional linebreak * Added example and note for Series.corr * Update frame.py * Added operation in example * Fixed indentation error for note * Relocated notes
Getting this error: Is it safe to change the superclass definition? @rhshadrach |
Yes - you'll also need to change the signature in NDFrame as well. |
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
numeric_only
to function signature ofDataFrameGroupBy.cumprod
and `DataFrameGroupBy.cumsum
#53071doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.