Skip to content

DOC: Fixing EX01 - Added examples #53880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Conversation

DeaMariaLeon
Copy link
Member

Towards #37875

@DeaMariaLeon DeaMariaLeon added this to the 2.1 milestone Jun 27, 2023
@mroeschke
Copy link
Member

Looks pretty good just a merge conflict

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! minor comment, seeing as this needs updating for the merge conflict anyway


Examples
--------
>>> file = pd.ExcelFile('myfile.xlsx') # doctest: +SKIP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to show it in an example of how it would be used? like

   with pd.ExcelFile("myfile.xls") as xls:
       df1 = pd.read_excel(xls, "Sheet1")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @DeaMariaLeon !

@MarcoGorelli MarcoGorelli merged commit 75af60b into pandas-dev:main Jun 28, 2023
@DeaMariaLeon DeaMariaLeon deleted the Jun-27 branch June 28, 2023 11:38
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* read_clipboard

* Examples read_clipboard, ExcelFile, ExcelFile.parse

* skip test for read_clipboard

* Added to ExcelFile example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants