DOC: Fixing EX01 - Added examples #53818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jun 23, 2023
pandas/core/dtypes/dtypes.py
Outdated
|
|
||
| Examples | ||
| -------- | ||
| >>> dtype = pd.DatetimeTZDtype(tz='dateutil/US/Central') |
There was a problem hiding this comment.
Could you use zoneinfo for the tz argument for these examples?
There was a problem hiding this comment.
I used the example from the reference forDatetimeTZDtype because I wasn't familiar with it. It also uses dateutil. Here is the link.
Please tell me if I should change that.
EDIT: Working on this (updated after review but incorrectly)
MarcoGorelli
approved these changes
Jun 26, 2023
| Examples | ||
| -------- | ||
| >>> dtype = pd.IntervalDtype(subtype='int64', closed='both') | ||
| >>> dtype.subtype |
There was a problem hiding this comment.
didn't know this existed, nice
mroeschke
approved these changes
Jun 26, 2023
|
Thanks @DeaMariaLeon |
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* Examples api.types, Sparse, TZDtype * Edited code_checks * Changed tz to zoneinfo * Added ZoneInfo for tz param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #37875