repr for PeriodIndex does not handle <=2 elements well (GH5372) #5376
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls try to name the issues and commits to something related to the issue (and just reference the issue, e.g. GH5372) |
|
@jreback sorry, changed name to more appropriate |
|
gr8 |
|
can you add a release notes entry refing this issue? (doc/source/release.rst) |
|
pls also rebase and squash: https://github.com/pydata/pandas/wiki/Using-Git |
| @@ -633,6 +633,8 @@ Bug Fixes | |||
| - Fixed issue with ``drop`` and a non-unique index on Series (:issue:`5248`) | |||
| - Fixed seg fault in C parser caused by passing more names than columns in | |||
| the file. (:issue:`5156`) | |||
| - Fixed bug for ``PeriodIndex`` string representation if there're then 1 or 2 | |||
There was a problem hiding this comment.
"there're then" ? => "there are"
|
@jreback hope I did it right |
|
the release notes look fine, but you need to squash... then then |
|
@jreback another try, sorry, used github only occasionally before |
jreback
added a commit
that referenced
this pull request
Oct 31, 2013
repr for PeriodIndex does not handle <=2 elements well (GH5372)
|
@RomanPekar thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5372