Skip to content

CI: fix numba typing #53730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2023
Merged

CI: fix numba typing #53730

merged 3 commits into from
Jun 20, 2023

Conversation

MarcoGorelli
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@MarcoGorelli MarcoGorelli added CI Continuous Integration Typing type annotations, mypy/pyright type checking labels Jun 19, 2023
@MarcoGorelli MarcoGorelli mentioned this pull request Jun 19, 2023
Merged
1 task
phofl
phofl reviewed Jun 19, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this broke tests

@MarcoGorelli
Copy link
Member Author

you're right, thanks - just gotta # type: ignore it

@phofl
Copy link
Member

phofl commented Jun 19, 2023

updated to get the other fixes in

@MarcoGorelli MarcoGorelli added this to the 2.0.3 milestone Jun 20, 2023
@MarcoGorelli
Copy link
Member Author

thanks for review - merging then to get CI green

@MarcoGorelli MarcoGorelli merged commit 047da25 into pandas-dev:main Jun 20, 2023
@lumberbot-app
Copy link

lumberbot-app bot commented Jun 20, 2023

Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out.

@MarcoGorelli
Copy link
Member Author

Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out.

right, Matt had already made this change on 2.0.x

Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@MarcoGorelli @phofl
CI: fix numba typing (pandas-dev#53730)
660fc11 
* fix numba typing

* type ignore

---------

Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGorelli @phofl