CI: fix pytest scripts

[MarcoGorelli]

seems that

def pytest_addoption(parser):
    parser.addoption(
        "--strict-data-files",
        action="store_true",
        help="Unused. For compat with setup.cfg.",
    )

isn't needed anymore, and actually errors now:

ValueError: option names {'--strict-data-files'} already added

[MarcoGorelli]

@kathleenhang I'd have forgotten this one, but your script caught it, thanks 🙌

[kathleenhang]

Thanks for the ping! It's really cool to see how it's helpful.

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout 2.0.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 3fb757beb6ca6bb30007ba1db130cc83f27f9363

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #53727: CI: fix `pytest scripts`'

4. Push to a named branch:

git push YOURFORK 2.0.x:auto-backport-of-pr-53727-on-2.0.x

5. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #53727 on branch 2.0.x (CI: fix pytest scripts)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

[phofl]

thx @MarcoGorelli

I guess we should backport?

[MarcoGorelli]

yeah probs

[mroeschke]

Why did pytest needed to be bumped? Technically we call out bumping these dev dependencies in the minor/major release whatsnews

[MarcoGorelli]

thanks @mroeschke , I'll make a PR to update this in the whatsnew

the reason is that the

def pytest_addoption(parser):
    parser.addoption(
        "--strict-data-files",
        action="store_true",
        help="Unused. For compat with setup.cfg.",
    )

options in scripts/conftest.py fail with a more modern pytest, so I figured it was easiest to just remove that and bump pytest

[mroeschke]

I think I am getting a related error in some PRs: https://github.com/pandas-dev/pandas/actions/runs/5383684555/jobs/9770736568?pr=53828

ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: --strict-data-files
  inifile: /home/runner/work/pandas/pandas/pyproject.toml
  rootdir: /home/runner/work/pandas/panda

Do you know why this is happening?

Also it appears minversion = "7.0" is still specified in pyproject.toml

[MarcoGorelli]

the logs show that that job is using:

pytest                         7.4.0 

My guess is that the issue might be in the pytest-localserver plugin?