Skip to content

BUG: inconsistent behavior of DateOffset #47953 #53681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 23, 2023
Merged

BUG: inconsistent behavior of DateOffset #47953 #53681

merged 14 commits into from
Jun 23, 2023

Conversation

rsm-23
Copy link
Contributor

@rsm-23 rsm-23 commented Jun 15, 2023 •
edited
Loading

@rsm-23 rsm-23 requested a review from MarcoGorelli as a code owner June 15, 2023 06:36
@MarcoGorelli
Copy link
Member

thanks for your PR - looks like some tests are failing, could you fix them up please?

FAILED pandas/tests/tseries/offsets/test_offsets.py::test_dateoffset_add_sub[offset_kwargs0-1970-01-01 00:00:00.000000001] - AssertionError
FAILED pandas/tests/tseries/offsets/test_offsets.py::test_dateoffset_add_sub[offset_kwargs1-1970-01-01 00:00:00.000000005] - AssertionError
FAILED pandas/tests/tseries/offsets/test_offsets.py::test_dateoffset_add_sub[offset_kwargs2-1969-12-31 23:59:59.999999999] - AssertionError
FAILED pandas/tests/tseries/offsets/test_offsets.py::test_dateoffset_add_sub_timestamp_with_nano - AssertionError

@rsm-23
Copy link
Contributor Author

rsm-23 commented Jun 15, 2023

I am looking into it.

@rsm-23
Copy link
Contributor Author

rsm-23 commented Jun 15, 2023

@MarcoGorelli the builds are passing now.

MarcoGorelli
MarcoGorelli suggested changes Jun 15, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @rsm-23 , thanks for working on this!

This is very close, just got two minor comments

@rsm-23 rsm-23 requested a review from MarcoGorelli June 16, 2023 03:43
MarcoGorelli
MarcoGorelli approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on green, thanks @rsm-23 !

@rsm-23 rsm-23 changed the title Dateoffset bug BUG: inconsistent behavior of DateOffset #47953 Jun 16, 2023
@rsm-23
Copy link
Contributor Author

rsm-23 commented Jun 16, 2023

@MarcoGorelli can you please help me understand the next steps for this PR?

@MarcoGorelli
Copy link
Member

I'll just leave this open a little to see if anyone else has comments/objections, and then will merge

@rsm-23
Copy link
Contributor Author

rsm-23 commented Jun 20, 2023

Hi @MarcoGorelli thanks for approving the PR. Any updates on this? TiA!

@mroeschke mroeschke added the Frequency DateOffsets label Jun 20, 2023
@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Jun 20, 2023
@rsm-23 rsm-23 requested a review from mroeschke June 21, 2023 08:11
@rsm-23 rsm-23 requested a review from mroeschke June 22, 2023 09:01
@MarcoGorelli
Copy link
Member

right, let's ship this 🚀

@MarcoGorelli MarcoGorelli merged commit 33199e1 into pandas-dev:main Jun 23, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@rsm-23
BUG: inconsistent behavior of DateOffset pandas-dev#47953 (pandas-dev…
cdb02e5 
…#53681)

* BUG: Fixed inconsistent multiplication pandas-dev#47953

* Fixed release note

* Fixed attribute name

* Changed offset apply logic

* Addressed pandas-dev#46877 re-occurence

* Removed dulicate code

* Addressed comments

* Added unit test cases

* Added mistakenly removed comment
@jrmylow jrmylow mentioned this pull request Nov 12, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke

Assignees
No one assigned
Labels
Frequency DateOffsets
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: inconsistent behavior of DateOffset
3 participants
@rsm-23 @MarcoGorelli @mroeschke