TST: xfail test_rolling_var_numerical_issues on Mac
#53661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed exclusion of mac from xfail
|
All checks passed. Now just waiting on review. Please let me know if any changes need to be made. |
|
This test is not passing on my M1 Macbook Pro. I think we should skip it for all arm chip Mac for now. |
fangchenli
reviewed
Jun 17, 2023
fangchenli
added
Build
Thank you for checking this! |
fangchenli
approved these changes
Jun 19, 2023
mroeschke
approved these changes
Jun 20, 2023
|
Thanks @Jython1415 |
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
modified xfail test_rolling_var_numerical_issues removed exclusion of mac from xfail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature. Change to testing only.Related to discussion starting from this comment on #38921. The test fails on with the Mac M2 chip, so this PR removes the exclusion of Mac from the xfail marker. Mac was previously excluded because the test passes on M1.