-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: Series.explode to support pyarrow-backed list types #53602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 5 commits into
pandas-dev:main
from
lukemanley:series-explode-pyarrow-list-type
Jun 13, 2023
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8ca57f2
ENH: Series.explode to support pyarrow-backed list types
lukemanley c93ee7b
gh refs
lukemanley 264dc41
update test
lukemanley d58e4ff
Merge remote-tracking branch 'upstream/main' into series-explode-pyar…
lukemanley c6c7d73
Merge remote-tracking branch 'upstream/main' into series-explode-pyar…
lukemanley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
import numpy as np | ||
import pytest | ||
|
||
from pandas.compat import pa_version_under7p0 | ||
|
||
import pandas as pd | ||
import pandas._testing as tm | ||
|
||
|
@@ -141,3 +143,25 @@ def test_explode_scalars_can_ignore_index(): | |
result = s.explode(ignore_index=True) | ||
expected = pd.Series([1, 2, 3]) | ||
tm.assert_series_equal(result, expected) | ||
|
||
|
||
@pytest.mark.skipif(pa_version_under7p0, reason="minimum pyarrow not installed") | ||
def test_explode_pyarrow_list_type(): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you parameterize on There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated |
||
# GH 53602 | ||
import pyarrow as pa | ||
|
||
data = [ | ||
[None, None], | ||
[1], | ||
[], | ||
[2, 3], | ||
None, | ||
] | ||
ser = pd.Series(data, dtype=pd.ArrowDtype(pa.list_(pa.int64()))) | ||
result = ser.explode() | ||
expected = pd.Series( | ||
data=[None, None, 1, None, 2, 3, None], | ||
index=[0, 0, 1, 2, 3, 3, 4], | ||
dtype=pd.ArrowDtype(pa.int64()), | ||
) | ||
tm.assert_series_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could you just use
pa = pytest.importorskip("pyarrow")
below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated