REF: move interpolate validation to core.missing #53580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jun 12, 2023
| @@ -225,6 +227,56 @@ def find_valid_index(how: str, is_valid: npt.NDArray[np.bool_]) -> int | None: | |||
| return idxpos # type: ignore[return-value] | |||
|
|
|||
|
|
|||
| def infer_limit_direction(limit_direction, method): | |||
There was a problem hiding this comment.
Doing so caused some trouble in part bc the NDFrame.interpolate annotation is inaccurate. ive got a interpolate-cleanup branch that im hoping improves the situation a bit, but the real solution is #53607
mroeschke
added
the
Missing-data
mroeschke
approved these changes
Jun 12, 2023
|
Thanks @jbrockmendel |
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* REF: move interpolate validation to core.missing * lint fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup found while working towards #50950.