Skip to content

FIX groupby with column selection not returning tuple when grouping by list of a single element #53517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 6, 2023

Conversation

Charlie-XIAO
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO commented Jun 4, 2023

@Charlie-XIAO Charlie-XIAO requested a review from rhshadrach as a code owner June 4, 2023 10:04
@rhshadrach
Copy link
Member

@Charlie-XIAO now that #53519 has been merged, the issues with nth should be fixed. Can you merge main.

@Charlie-XIAO
Copy link
Contributor Author

@Charlie-XIAO now that #53519 has been merged, the issues with nth should be fixed. Can you merge main.

Sure, will do.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A small request on the test.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 2.1 milestone Jun 6, 2023
@rhshadrach rhshadrach merged commit 5ceebe9 into pandas-dev:main Jun 6, 2023
@rhshadrach
Copy link
Member

Thanks @Charlie-XIAO!

@Charlie-XIAO Charlie-XIAO deleted the grpby-lst-of-one-keys branch June 28, 2023 05:41
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: column selection in GroupBy NOT returning tuple when grouping by a list containing single element
3 participants