DEPR: Period[B] #53511
DEPR: Period[B] #53511
Conversation
mroeschke
added
Frequency
| @@ -217,6 +217,7 @@ def test_line_plot_period_mlt_frame(self, frqncy): | |||
| freq = df.index.asfreq(df.index.freq.rule_code).freq | |||
| _check_plot_works(df.plot, freq) | |||
|
|
|||
| @pytest.mark.filterwarnings(r"ignore:PeriodDtype\[B\] is deprecated:FutureWarning") | |||
There was a problem hiding this comment.
do we need to find a workaround in plotting before doing this?
There was a problem hiding this comment.
yes. suppressing the warning on this test is OK, but i think we need a better solution than suppressing here https://github.com/pandas-dev/pandas/pull/53511/files#diff-9e7653bee8c4fb4e42459af383020b7d754df6c55e79680d20e81d588d51f029R283
|
+1 on deprecating. What about the other Business offsets? |
The other business offsets aren't used for Period. (Confusion about that is common, which is part of why i want to decouple offsets from Period entirely) |
pandas/_testing/__init__.py
Outdated
| return pd.period_range(start=dt, periods=k, freq="B", name=name, **kwargs) | ||
| with warnings.catch_warnings(): | ||
| warnings.simplefilter("ignore") | ||
| pi = pd.period_range(start=dt, periods=k, freq="B", name=name, **kwargs) |
There was a problem hiding this comment.
Is it possible to use another freq like "D"?
There was a problem hiding this comment.
Doing that breaks a handful of tests. I could go either way on changing it now vs after enforcement.
There was a problem hiding this comment.
Would slightly prefer changing now to hopefully prevent potentially having to change more tests in the future
There was a problem hiding this comment.
Fair enough, updated
pandas/tests/resample/conftest.py
Outdated
| rng = period_range(start, end, freq=freq) | ||
| with warnings.catch_warnings(): | ||
| # suppress Period[B] deprecation warning | ||
| warnings.simplefilter("ignore") |
There was a problem hiding this comment.
could we be more precise with the simplefilter please? I think this may set a bad example for new contributors wanting to silence warnings and looking for existing patterns of how to do it
There was a problem hiding this comment.
good point, will update
|
Thanks @jbrockmendel |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.There's a place in the plotting code where we apparently cast to Period, not sure why that would be necessary. Need to find an alternative before the deprecation is enforced.