CI: Bump builds to 3.11, update numpy nightly wheels location #53508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
approved these changes
Jun 4, 2023
lithomas1
reviewed
Jun 4, 2023
pandas/core/window/rolling.py
Outdated
| @@ -1140,7 +1140,7 @@ def _validate(self): | |||
| if not isinstance(self.win_type, str): | |||
| raise ValueError(f"Invalid win_type {self.win_type}") | |||
| signal = import_optional_dependency( | |||
| "scipy.signal", extra="Scipy is required to generate window weight." | |||
| "scipy.signal.window", extra="Scipy is required to generate window weight." | |||
There was a problem hiding this comment.
Suggested change
| "scipy.signal.window", extra="Scipy is required to generate window weight." | |
| "scipy.signal.windows", extra="Scipy is required to generate window weight." |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
mroeschke
added a commit
to mroeschke/pandas
that referenced
this pull request
Jun 6, 2023
…-dev#53508) * CI: Bump builds to 3.11, update numpy nightly wheels location * Move arm to 3.10 instead * Change scipy window api * plural * Use stable sort? (cherry picked from commit 21a81e9)
mroeschke
added a commit
that referenced
this pull request
Jun 8, 2023
#53541) * CI: Bump builds to 3.11, update numpy nightly wheels location (#53508) * CI: Bump builds to 3.11, update numpy nightly wheels location * Move arm to 3.10 instead * Change scipy window api * plural * Use stable sort? (cherry picked from commit 21a81e9) * Fix files * fix typing * undo sorting changes
5 tasks
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…-dev#53508) * CI: Bump builds to 3.11, update numpy nightly wheels location * Move arm to 3.10 instead * Change scipy window api * plural * Use stable sort?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.